netdev - Re: [PATCH net] ipv6/mcast: update mc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181029.202356.802822894497287155.davem@davemloft.net>
Date:   Mon, 29 Oct 2018 20:23:56 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     liuhangbin@...il.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net] ipv6/mcast: update mc_qrv when join new group

From: Hangbin Liu <liuhangbin@...il.com>
Date: Fri, 26 Oct 2018 10:30:54 +0800

> Currently we only set mc_qrv to sysctl_mld_qrv when interface up. If we
> change sysctl_mld_qrv after interface up, it will has no effect.
> 
> Fix it by assigning latest sysctl_mld_qrv to idev mc_qrv when join new group.
> 
> Reported-by: Ying Xu <yinxu@...hat.com>
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>

Why isn't mld_update_qrv() taking care of this?

At a minimum, you must make your change take MLD_QRV_DEFAULT etc.
into account like mld_update_qrv() does.