netdev - Re: [PATCH net] ipv6/mcast: update mc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 8 Nov 2018 15:44:10 +0800
From:   Hangbin Liu <liuhangbin@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net] ipv6/mcast: update mc_qrv when join new group

On Fri, Oct 26, 2018 at 10:30:54AM +0800, Hangbin Liu wrote:
> Currently we only set mc_qrv to sysctl_mld_qrv when interface up. If we
> change sysctl_mld_qrv after interface up, it will has no effect.
> 
> Fix it by assigning latest sysctl_mld_qrv to idev mc_qrv when join new group.
> 
> Reported-by: Ying Xu <yinxu@...hat.com>
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>

Hi David,

Any comments for this patch?

Thanks
Hangbin
> ---
>  net/ipv6/mcast.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/net/ipv6/mcast.c b/net/ipv6/mcast.c
> index dbab62e..bed4890 100644
> --- a/net/ipv6/mcast.c
> +++ b/net/ipv6/mcast.c
> @@ -680,6 +680,7 @@ static void igmp6_group_added(struct ifmcaddr6 *mc)
>  	if (!(dev->flags & IFF_UP) || (mc->mca_flags & MAF_NOREPORT))
>  		return;
>  
> +	mc->idev->mc_qrv = sysctl_mld_qrv;
>  	if (mld_in_v1_mode(mc->idev)) {
>  		igmp6_join_group(mc);
>  		return;
> -- 
> 2.5.5
>