netdev - Re: [PATCH 1/2] net:stmmac: dwmac-mediatek: add support for mt2712

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 30 Oct 2018 12:56:38 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     biao huang <biao.huang@...iatek.com>
Cc:     Corentin Labbe <clabbe.montjoie@...il.com>, davem@...emloft.net,
        robh+dt@...nel.org, mark.rutland@....com,
        devicetree@...r.kernel.org, nelson.chang@...iatek.com,
        netdev@...r.kernel.org, sean.wang@...iatek.com,
        liguo.zhang@...iatek.com, linux-kernel@...r.kernel.org,
        matthias.bgg@...il.com, joabreu@...opsys.com,
        linux-mediatek@...ts.infradead.org, honghui.zhang@...iatek.com,
        yt.shen@...iatek.com, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/2] net:stmmac: dwmac-mediatek: add support for mt2712

> > > +	plat_dat->interface = priv_plat->phy_mode;
> > > +	/* clk_csr_i = 250-300MHz & MDC = clk_csr_i/124 */
> > > +	plat_dat->clk_csr = 5;
> > > +	plat_dat->has_gmac4 = 1;
> > > +	plat_dat->has_gmac = 0;
> > > +	plat_dat->pmt = 0;
> > > +	plat_dat->maxmtu = 1500;
> > 
> > ETH_DATA_LEN ?
> how about getting maxmtu from device tree rather than assignment here?

Does it vary between devices? I expect it is a constant, determined by
the DMA hardware design. So no need to make it configurabale.

    Andrew