netdev - Re: [RFC PATCH] net/mlx5e: Temp software stats variable is not required

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181103.193617.810293775666516890.davem@davemloft.net>
Date:   Sat, 03 Nov 2018 19:36:17 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     saeedm@...lanox.com
Cc:     netdev@...r.kernel.org, arnd@...db.de, akpm@...ux-foundation.org,
        jgg@...lanox.com, eric.dumazet@...il.com, eranbe@...lanox.com,
        leonro@...lanox.com
Subject: Re: [RFC PATCH] net/mlx5e: Temp software stats variable is not
 required

From: Saeed Mahameed <saeedm@...lanox.com>
Date: Fri,  2 Nov 2018 18:54:22 -0700

> +static void mlx5e_fold_sw_stats(struct mlx5e_priv *priv, struct rtnl_link_stats64 *s)
> +{
> +	int i;
> +
> +	/* not required ? */
> +	memset(s, 0, sizeof(*s));

Why wouldn't this be required?

I can see that perhaps you can only zero out the statistics that are used in
the ndo_get_stats64() code path, but that's different.