netdev - Re: [PATCH] qed: fix link config error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181103.192753.1631072685342336213.davem@davemloft.net>
Date:   Sat, 03 Nov 2018 19:27:53 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     arnd@...db.de
Cc:     Ariel.Elior@...ium.com, everest-linux-l2@...ium.com,
        sudarsana.kalluru@...ium.com, Tomer.Tayar@...ium.com,
        denis.bolotin@...ium.com, Rahul.Verma@...ium.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] qed: fix link config error handling

From: Arnd Bergmann <arnd@...db.de>
Date: Fri,  2 Nov 2018 16:36:24 +0100

> gcc-8 notices that qed_mcp_get_transceiver_data() may fail to
> return a result to the caller:
> 
> drivers/net/ethernet/qlogic/qed/qed_mcp.c: In function 'qed_mcp_trans_speed_mask':
> drivers/net/ethernet/qlogic/qed/qed_mcp.c:1955:2: error: 'transceiver_type' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> 
> When an error is returned by qed_mcp_get_transceiver_data(), we
> should propagate that to the caller of qed_mcp_trans_speed_mask()
> rather than continuing with uninitialized data.
> 
> Fixes: c56a8be7e7aa ("qed: Add supported link and advertise link to display in ethtool.")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied, thanks.