netdev - Re: [PATCH net-next 2/2] net: phy: realtek: remove boilerplate code from driver configs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181108183721.GE5259@lunn.ch>
Date:   Thu, 8 Nov 2018 19:37:21 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        David Miller <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 2/2] net: phy: realtek: remove boilerplate code
 from driver configs

>  	{
>  		.phy_id         = 0x00008201,
>  		.name           = "RTL8201CP Ethernet",
> -		.phy_id_mask    = 0x0000ffff,
>  		.features       = PHY_BASIC_FEATURES,
>  		.flags          = PHY_HAS_INTERRUPT,
>  	}, {
>  		.phy_id		= 0x001cc816,
>  		.name		= "RTL8201F Fast Ethernet",
> -		.phy_id_mask	= 0x001fffff,

Hi Heiner

"RTL8201CP Ethernet" has a mask of 0x0000ffff, where as all the others
use 0x001fffff. Is this correct?

    Andrew