netdev - Re: [PATCH net-next 2/2] net: phy: realtek: remove boilerplate code from driver configs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <262b52e8-6823-ea9a-5730-2d018b953093@gmail.com>
Date:   Thu, 8 Nov 2018 20:38:49 +0100
From:   Heiner Kallweit <hkallweit1@...il.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        David Miller <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 2/2] net: phy: realtek: remove boilerplate code
 from driver configs

On 08.11.2018 19:37, Andrew Lunn wrote:
>>  	{
>>  		.phy_id         = 0x00008201,
>>  		.name           = "RTL8201CP Ethernet",
>> -		.phy_id_mask    = 0x0000ffff,
>>  		.features       = PHY_BASIC_FEATURES,
>>  		.flags          = PHY_HAS_INTERRUPT,
>>  	}, {
>>  		.phy_id		= 0x001cc816,
>>  		.name		= "RTL8201F Fast Ethernet",
>> -		.phy_id_mask	= 0x001fffff,
> 
> Hi Heiner
> 
> "RTL8201CP Ethernet" has a mask of 0x0000ffff, where as all the others
> use 0x001fffff. Is this correct?
> 
IMO none of the masks is correct. All of them should be 0xffffffff.
Nowadays the 32 bit PHYID  is assembled from (MSB to LSB):
22 bits vendor OUI, 6 bit model number, 4 bit revision number
Just the old 8201 doesn't follow this scheme.

With the current masks, a PHYID 0x12348201 would be recognized as
Realtek 8201 too, what's obviously wrong.

>     Andrew
>