lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 08 Nov 2018 16:20:06 -0800 (PST) From: David Miller <davem@...emloft.net> To: jakub.kicinski@...ronome.com Cc: netdev@...r.kernel.org, oss-drivers@...ronome.com, jiri@...nulli.us, xiyou.wangcong@...il.com, jhs@...atatu.com, nogah.frankel@...il.com, yuvalm@...lanox.com Subject: Re: [PATCH net-next 0/7] net: sched: prepare for more Qdisc offloads From: Jakub Kicinski <jakub.kicinski@...ronome.com> Date: Wed, 7 Nov 2018 17:33:33 -0800 > This series refactors the "switchdev" Qdisc offloads a little. We have > a few Qdiscs which can be fully offloaded today to the forwarding plane > of switching devices. > > First patch adds a helper for handing statistic dumps, the code seems > to be copy pasted between PRIO and RED. Second patch removes unnecessary > parameter from RED offload function. Third patch makes the MQ offload > use the dump helper which helps it behave much like PRIO and RED when > it comes to the TCQ_F_OFFLOADED flag. Patch 4 adds a graft helper, > similar to the dump helper. > > Patch 5 is unrelated to offloads, qdisc_graft() code seemed ripe for a > small refactor - no functional changes there. > > Last two patches move the qdisc_put() call outside of the sch_tree_lock > section for RED and PRIO. The child Qdiscs will get removed from the > hierarchy under the lock, but having the put (and potentially destroy) > called outside of the lock helps offload which may choose to sleep, > and it should generally lower the Qdisc change impact. Series applied, thanks Jakub.
Powered by blists - more mailing lists