netdev - Re: [PATCH net-next] net: bcmgenet: return correct value 'ret' from bcmgenet_power

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181108.162201.360454923619072769.davem@davemloft.net>
Date:   Thu, 08 Nov 2018 16:22:01 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     yuehaibing@...wei.com
Cc:     opendmb@...il.com, f.fainelli@...il.com, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: bcmgenet: return correct value 'ret'
 from bcmgenet_power_down

From: YueHaibing <yuehaibing@...wei.com>
Date: Thu, 8 Nov 2018 02:08:43 +0000

> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/net/ethernet/broadcom/genet/bcmgenet.c: In function 'bcmgenet_power_down':
> drivers/net/ethernet/broadcom/genet/bcmgenet.c:1136:6: warning:
>  variable 'ret' set but not used [-Wunused-but-set-variable]
> 
> bcmgenet_power_down should return 'ret' instead of 0.
> 
> Fixes: ca8cf341903f ("net: bcmgenet: propagate errors from bcmgenet_power_down")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Applied, thanks.