netdev - Re: [PATCH net 4/5] net/smc: atomic SMCD cursor handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181113.145347.202584017982412625.davem@davemloft.net>
Date:   Tue, 13 Nov 2018 14:53:47 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     ubraun@...ux.ibm.com
Cc:     netdev@...r.kernel.org, linux-s390@...r.kernel.org,
        schwidefsky@...ibm.com, heiko.carstens@...ibm.com,
        raspl@...ux.ibm.com
Subject: Re: [PATCH net 4/5] net/smc: atomic SMCD cursor handling

From: Ursula Braun <ubraun@...ux.ibm.com>
Date: Mon, 12 Nov 2018 17:01:32 +0100

> +/* SMC-D cursor format */
> +union smcd_cdc_cursor {
 ...
> +} __aligned(8);

>  struct smcd_cdc_msg {
 ...
> +	union smcd_cdc_cursor	prod;
> +	union smcd_cdc_cursor	cons;
>  	u8 res3[8];
>  } __packed;

You're asking for 8-byte alignment of an object you only embed in a
__packed structure, which therefore has arbitary alignment.

It's not going to work.