netdev - Re: [iproute PATCH] ip-address: Fix filtering by negated address flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 13 Nov 2018 14:47:59 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Phil Sutter <phil@....cc>
Cc:     netdev@...r.kernel.org
Subject: Re: [iproute PATCH] ip-address: Fix filtering by negated address
 flags

On Tue, 13 Nov 2018 16:12:01 +0100
Phil Sutter <phil@....cc> wrote:

> +	if (arg[0] == '-') {
> +		inv = true;
> +		arg++;
> +	}
The inverse logic needs to be moved into the loop handling filter names.

Otherwise, you get weirdness like "-dynamic" being accepted and not
doing what was expected.

Also, please make sure the man page matches the code.