netdev - Re: [PATCH] bpf: Remove unused variable in nsim

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <427c8392-ed04-d0bd-76bf-21af79a71eeb@netronome.com>
Date:   Tue, 13 Nov 2018 06:07:08 +0000
From:   Quentin Monnet <quentin.monnet@...ronome.com>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>,
        Nathan Chancellor <natechancellor@...il.com>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bpf: Remove unused variable in nsim_bpf

2018-11-12 14:14 UTC-0800 ~ Jakub Kicinski <jakub.kicinski@...ronome.com>
> On Mon, 12 Nov 2018 15:10:42 -0700, Nathan Chancellor wrote:
>> Clang warns:
>>
>> drivers/net/netdevsim/bpf.c:557:30: error: unused variable 'state'
>> [-Werror,-Wunused-variable]
>>         struct nsim_bpf_bound_prog *state;
>>                                     ^
>> 1 error generated.
>>
>> The declaration should have been removed in commit b07ade27e933 ("bpf:
>> pass translate() as a callback and remove its ndo_bpf subcommand").
>>
>> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>
> 
> Acked-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
> 

My bad, thanks for the fix!

Acked-by: Quentin Monnet <quentin.monnet@...ronome.com>