netdev - Re: [PATCH net] net/sched: act_pedit: fix memory leak when IDR allocation fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpW_KJW2kwt-EMo0kbCaNoEr_WAOiLWin9MJEnG50pQ1fA@mail.gmail.com>
Date:   Wed, 14 Nov 2018 12:36:16 -0800
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Davide Caratti <dcaratti@...hat.com>
Cc:     Jiri Pirko <jiri@...lanox.com>, David Miller <davem@...emloft.net>,
        Vlad Buslov <vladbu@...lanox.com>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Jamal Hadi Salim <jhs@...atatu.com>
Subject: Re: [PATCH net] net/sched: act_pedit: fix memory leak when IDR
 allocation fails

(Cc'ing Jamal)

On Wed, Nov 14, 2018 at 3:26 AM Davide Caratti <dcaratti@...hat.com> wrote:
>
> tcf_idr_check_alloc() can return a negative value, on allocation failures
> (-ENOMEM) or IDR exhaustion (-ENOSPC): don't leak keys_ex in these cases.

I think the comments above tcf_idr_check_alloc() need to improve too,
they imply tcf_idr_check_alloc() returns either 0 or 1.

Of course, this can be done with a separated patch.

>
> Fixes: 0190c1d452a9 ("net: sched: atomically check-allocate action")
> Signed-off-by: Davide Caratti <dcaratti@...hat.com>

I think your patch is correct.

Acked-by: Cong Wang <xiyou.wangcong@...il.com>