netdev - Re: [PATCH net] net/sched: act_pedit: fix memory leak when IDR allocation fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181116.195436.843627953110137323.davem@davemloft.net>
Date:   Fri, 16 Nov 2018 19:54:36 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     dcaratti@...hat.com
Cc:     jiri@...lanox.com, vladbu@...lanox.com, netdev@...r.kernel.org
Subject: Re: [PATCH net] net/sched: act_pedit: fix memory leak when IDR
 allocation fails

From: Davide Caratti <dcaratti@...hat.com>
Date: Wed, 14 Nov 2018 12:17:25 +0100

> tcf_idr_check_alloc() can return a negative value, on allocation failures
> (-ENOMEM) or IDR exhaustion (-ENOSPC): don't leak keys_ex in these cases.
> 
> Fixes: 0190c1d452a9 ("net: sched: atomically check-allocate action")
> Signed-off-by: Davide Caratti <dcaratti@...hat.com>

Applied and queued up for -stable, thanks.