netdev - Re: [net-next PATCH v4] net: sched: cls_flower: Classify packets using port ranges

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 15 Nov 2018 11:39:14 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     amritha.nambiar@...el.com
Cc:     netdev@...r.kernel.org, jakub.kicinski@...ronome.com,
        sridhar.samudrala@...el.com, jhs@...atatu.com,
        xiyou.wangcong@...il.com, jiri@...nulli.us
Subject: Re: [net-next PATCH v4] net: sched: cls_flower: Classify packets
 using port ranges

From: Amritha Nambiar <amritha.nambiar@...el.com>
Date: Mon, 12 Nov 2018 16:15:55 -0800

> Added support in tc flower for filtering based on port ranges.
> 
> Example:
 ...
> v4:
> 1. Added condition before setting port key.
> 2. Organized setting and dumping port range keys into functions
>    and added validation of input range.
> 
> v3:
> 1. Moved new fields in UAPI enum to the end of enum.
> 2. Removed couple of empty lines.
> 
> v2:
> Addressed Jiri's comments:
> 1. Added separate functions for dst and src comparisons.
> 2. Removed endpoint enum.
> 3. Added new bit TCA_FLOWER_FLAGS_RANGE to decide normal/range
>   lookup.
> 4. Cleaned up fl_lookup function.
> 
> Signed-off-by: Amritha Nambiar <amritha.nambiar@...el.com>

Applied.