netdev - Re: [PATCH net] net_sched: sch_fq: ensure maxrate fq parameter applies to EDT flows

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181115.114244.2161851080298657768.davem@davemloft.net>
Date:   Thu, 15 Nov 2018 11:42:44 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net] net_sched: sch_fq: ensure maxrate fq parameter
 applies to EDT flows

From: Eric Dumazet <edumazet@...gle.com>
Date: Mon, 12 Nov 2018 16:17:16 -0800

> When EDT conversion happened, fq lost the ability to enfore a maxrate
> for all flows. It kept it for non EDT flows.
> 
> This commit restores the functionality.
> 
> Tested:
> 
> tc qd replace dev eth0 root fq maxrate 500Mbit
> netperf -P0 -H host -- -O THROUGHPUT
> 489.75
> 
> Fixes: ab408b6dc744 ("tcp: switch tcp and sch_fq to new earliest departure time model")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied, thanks Eric.