netdev - Re: [PATCH 10/11] nvmet-tcp: add NVMe over TCP target driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <59335e55-7e19-3201-2f8b-beb681aba810@mellanox.com>
Date:   Sun, 18 Nov 2018 00:48:57 +0200
From:   Max Gurtovoy <maxg@...lanox.com>
To:     David Miller <davem@...emloft.net>, <sagi@...htbitslabs.com>
CC:     <linux-nvme@...ts.infradead.org>, <linux-block@...r.kernel.org>,
        <netdev@...r.kernel.org>, <hch@....de>, <keith.busch@...el.com>
Subject: Re: [PATCH 10/11] nvmet-tcp: add NVMe over TCP target driver


On 11/17/2018 10:15 PM, David Miller wrote:
> From: Sagi Grimberg <sagi@...htbitslabs.com>
> Date: Thu, 15 Nov 2018 09:16:22 -0800
>
>> +static unsigned nvmet_tcp_recv_budget = 8;
>> +module_param_named(recv_budget, nvmet_tcp_recv_budget, int, S_IRUGO | S_IWUSR);
>> +MODULE_PARM_DESC(recv_budget, "recvs budget");
>> +
>> +static unsigned nvmet_tcp_send_budget = 8;
>> +module_param_named(send_budget, nvmet_tcp_send_budget, int, S_IRUGO | S_IWUSR);
>> +MODULE_PARM_DESC(send_budget, "sends budget");
>> +
>> +static unsigned nvmet_tcp_io_work_budget = 64;
>> +module_param_named(io_work_budget, nvmet_tcp_io_work_budget, int, S_IRUGO | S_IWUSR);
>> +MODULE_PARM_DESC(io_work_budget, "io work budget");
> I strongly suggest moving away from module parameters for this stuff.

agree here.

also, Sagi, can you explain about the performance trade-offs seen during 
your development for these values ?

are they HCA/NIC dependent ?

should send/recv ratio be 1:1 ?

should total/send/recv ratio be 8:1:1 ?


>
> Create a genetlink socket family and allow run time configuration of these knobs
> by the user.
>
> Thanks.