netdev - Re: [PATCH 05/11] nvmet: Add install

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <98230184-074a-84cf-3aa5-8ad30f2b5339@grimberg.me>
Date:   Mon, 19 Nov 2018 13:21:58 -0800
From:   Sagi Grimberg <sagi@...mberg.me>
To:     Max Gurtovoy <maxg@...lanox.com>,
        Sagi Grimberg <sagi@...htbitslabs.com>,
        linux-nvme@...ts.infradead.org
Cc:     linux-block@...r.kernel.org, netdev@...r.kernel.org,
        Keith Busch <keith.busch@...el.com>,
        Christoph Hellwig <hch@....de>
Subject: Re: [PATCH 05/11] nvmet: Add install_queue callout


>> diff --git a/drivers/nvme/target/fabrics-cmd.c 
>> b/drivers/nvme/target/fabrics-cmd.c
>> index 1f05d8507e35..a84668e8939c 100644
>> --- a/drivers/nvme/target/fabrics-cmd.c
>> +++ b/drivers/nvme/target/fabrics-cmd.c
>> @@ -117,6 +117,15 @@ static u16 nvmet_install_queue(struct nvmet_ctrl 
>> *ctrl, struct nvmet_req *req)
>>       nvmet_sq_setup(ctrl, req->sq, qid, sqsize + 1,
>>               !!(c->cattr & NVME_CONNECT_DISABLE_SQFLOW));
> 
> what is your code base ? does SQFLOW must for TCP ?

Not really, just happens to sit on top..

>> +    if (ctrl->ops->install_queue) {
>> +        int ret = ctrl->ops->install_queue(req->sq);
>> +        if (ret) {
>> +            pr_err("failed to install queue %d cntlid %d ret %d\n",
>> +                qid, ret, ctrl->cntlid);
>> +            return NVME_SC_CONNECT_INVALID_PARAM | NVME_SC_DNR;
> 
> I'm not sure regarding the INVALID_PARAM rc.
> 
> maybe use NVME_SC_INTERNAL ?

You're right, perhaps we should propagate ->install_queue() status.