netdev - Re: [PATCH net-next 1/8] net: eth: altera: tse_start_xmit ignores tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181116.203800.1372283941971325282.davem@davemloft.net>
Date:   Fri, 16 Nov 2018 20:38:00 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     dwesterg@...il.com
Cc:     netdev@...r.kernel.org, dinguyen@...nel.org,
        thor.thayer@...ux.intel.com, dalon.westergreen@...el.com
Subject: Re: [PATCH net-next 1/8] net: eth: altera: tse_start_xmit ignores
 tx_buffer call response

From: Dalon Westergreen <dwesterg@...il.com>
Date: Wed, 14 Nov 2018 16:50:40 -0800

> @@ -202,7 +204,7 @@ int sgdma_tx_buffer(struct altera_tse_private *priv, struct tse_buffer *buffer)
>  	/* enqueue the request to the pending transmit queue */
>  	queue_tx(priv, buffer);
>  
> -	return 1;
> +	return 0;

NETDEV_TX_OK.

And now you can make all of these functions properly return netdev_tx_t instead of int.