netdev - Re: [PATCH net-next 1/8] net: eth: altera: tse_start_xmit ignores tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0de0bb6fe59df5601105939036c33f12edc593e2.camel@intel.com>
Date:   Sat, 17 Nov 2018 15:29:17 +0000
From:   "Westergreen, Dalon" <dalon.westergreen@...el.com>
To:     "davem@...emloft.net" <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "dinguyen@...nel.org" <dinguyen@...nel.org>,
        "thor.thayer@...ux.intel.com" <thor.thayer@...ux.intel.com>
Subject: Re: [PATCH net-next 1/8] net: eth: altera: tse_start_xmit ignores
 tx_buffer call response

On Fri, 2018-11-16 at 20:38 -0800, David Miller wrote:
> From: Dalon Westergreen <dwesterg@...il.com>
> Date: Wed, 14 Nov 2018 16:50:40 -0800
> 
> > @@ -202,7 +204,7 @@ int sgdma_tx_buffer(struct altera_tse_private *priv,
> struct tse_buffer *buffer)
> >       /* enqueue the request to the pending transmit queue */
> >       queue_tx(priv, buffer);
> >  
> > -     return 1;
> > +     return 0;
> 
> NETDEV_TX_OK.
> 
> And now you can make all of these functions properly return netdev_tx_t
> instead of int.

sure thing.

--dalon

Download attachment "smime.p7s" of type "application/x-pkcs7-signature" (3282 bytes)