netdev - Re: [PATCH net-next 0/7] net: sched: gred: introduce per-virtual queue attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181116.231943.1316025515128598765.davem@davemloft.net>
Date:   Fri, 16 Nov 2018 23:19:43 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     jakub.kicinski@...ronome.com
Cc:     netdev@...r.kernel.org, jiri@...nulli.us, xiyou.wangcong@...il.com,
        jhs@...atatu.com, oss-drivers@...ronome.com
Subject: Re: [PATCH net-next 0/7] net: sched: gred: introduce per-virtual
 queue attributes

From: Jakub Kicinski <jakub.kicinski@...ronome.com>
Date: Wed, 14 Nov 2018 22:23:44 -0800

> This series updates the GRED Qdisc.  The Qdisc matches nfp offload very
> well, but before we can offload it there are a number of improvements
> to make.
> 
> First few patches add extack messages to the Qdisc and pass extack
> to netlink validation.
> 
> Next a new netlink attribute group is added, to allow GRED to be
> extended more easily.  Currently GRED passes C structures as attributes,
> and even an array of C structs for virtual queue configuration.  User
> space has hard coded the expected length of that array, so adding new
> fields is not possible.
> 
> New two-level attribute group is added:
> 
>   [TCA_GRED_VQ_LIST]
>     [TCA_GRED_VQ_ENTRY]
>       [TCA_GRED_VQ_DP]
>       [TCA_GRED_VQ_FLAGS]
>       [TCA_GRED_VQ_STAT_*]
>     [TCA_GRED_VQ_ENTRY]
>       [TCA_GRED_VQ_DP]
>       [TCA_GRED_VQ_FLAGS]
>       [TCA_GRED_VQ_STAT_*]
>     [TCA_GRED_VQ_ENTRY]
>        ...
> 
> Statistics are dump only. Patch 4 switches the byte counts to be 64 bit,
> and patch 5 introduces the new stats attributes for dump.  Patch 6
> switches RED flags to be per-virtual queue, and patch 7 allows them
> to be dumped and set at virtual queue granularity.

Nice work, series applied.