netdev - Re: [PATCH v2 04/21] octeontx2-af: Relax resource lock into mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181116.232029.1020305436916652001.davem@davemloft.net>
Date:   Fri, 16 Nov 2018 23:20:29 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     sunil.kovvuri@...il.com
Cc:     netdev@...r.kernel.org, arnd@...db.de, linux-soc@...r.kernel.org,
        skardach@...vell.com, sgoutham@...vell.com
Subject: Re: [PATCH v2 04/21] octeontx2-af: Relax resource lock into mutex

From: sunil.kovvuri@...il.com
Date: Thu, 15 Nov 2018 16:29:29 +0530

> From: Stanislaw Kardach <skardach@...vell.com>
> 
> The resource locks does not need to be a spinlock as they are not
> used in any interrupt handling routines (only in bottom halves).
> Therefore relax them into a mutex so that later on we may use them
> in routines that might sleep.
> 
> Signed-off-by: Stanislaw Kardach <skardach@...vell.com>
> Signed-off-by: Sunil Goutham <sgoutham@...vell.com>

This is confusing because software interrupts are often called bottom
halves, and in which sleeping and thus mutexes are not allowed.