netdev - Re: [PATCH net V3 0/5] net/smc: fixes 2018-11-12

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181117.212951.1737614895221053174.davem@davemloft.net>
Date:   Sat, 17 Nov 2018 21:29:51 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     ubraun@...ux.ibm.com
Cc:     netdev@...r.kernel.org, linux-s390@...r.kernel.org,
        schwidefsky@...ibm.com, heiko.carstens@...ibm.com,
        raspl@...ux.ibm.com
Subject: Re: [PATCH net V3 0/5] net/smc: fixes 2018-11-12

From: Ursula Braun <ubraun@...ux.ibm.com>
Date: Fri, 16 Nov 2018 13:36:12 +0100

> v2->v3:
>    stay with 8-byte alignment for union smcd_cdc_cursor in
>    patch 4/5 "net/smc: atomic SMCD cursor handling", but get rid of
>    __packed for struct smcd_cdc_msg

This SMC-D message is defined in some standard somewhere, right?  So
if this __packed removal changes the layout it will break things.

I see smc_cdc_msg has the same issue, and it's layout is defined in
RFC7609.

If the __packed removal doesn't change the layout, you should remove it
from smc_cdc_msg too for consistency.

This is why I tell people to never use __packed.