netdev - Re: [PATCH] socket: do a generic_file_splice_read when proto_ops has no splice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181117.213424.2216362796439531714.davem@davemloft.net>
Date:   Sat, 17 Nov 2018 21:34:24 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     kaslevs@...are.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] socket: do a generic_file_splice_read when proto_ops
 has no splice_read

From: kaslevs@...are.com
Date: Fri, 16 Nov 2018 11:27:53 +0200

> From: Slavomir Kaslev <kaslevs@...are.com>
> 
> splice(2) fails with -EINVAL when called reading on a socket with no splice_read
> set in its proto_ops (such as vsock sockets). Switch this to fallbacks to a
> generic_file_splice_read instead.
> 
> Signed-off-by: Slavomir Kaslev <kaslevs@...are.com>

Applied.

I wonder why we left things this way for so long.