netdev - Re: netns_id in bpf_sk_lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <90ae2d6b-049a-90a2-05e5-66700e885b39@gmail.com>
Date:   Mon, 19 Nov 2018 11:39:14 -0700
From:   David Ahern <dsahern@...il.com>
To:     Joe Stringer <joe@...d.net.nz>
Cc:     netdev <netdev@...r.kernel.org>, daniel@...earbox.net
Subject: Re: netns_id in bpf_sk_lookup_{tcp,udp}

On 11/19/18 11:36 AM, Joe Stringer wrote:
> Hi David, thanks for pointing this out.
> 
> This is more of an oversight through iterations, the runtime lookup
> will fail to find a socket if the netns value is greater than the
> range of a uint32 so I think it would actually make more sense to drop
> the parameter size to u32 rather than u64 so that this would be
> validated at load time rather than silently returning NULL because of
> a bad parameter.

ok. I was wondering if it was a u64 to handle nsid of 0 which as I
understand it is a legal nsid. If you drop to u32, how do you know when
nsid has been set?

> 
> I'll send a patch to bpf tree.
> 
ok.