netdev - Re: [PATCH v3 net-next 13/21] net: usb: aqc111: Add support for TSO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 22 Nov 2018 11:17:21 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     Igor.Russkikh@...antia.com
Cc:     linux-usb@...r.kernel.org, netdev@...r.kernel.org, andrew@...n.ch,
        Dmitry.Bezrukov@...antia.com
Subject: Re: [PATCH v3 net-next 13/21] net: usb: aqc111: Add support for TSO

From: Igor Russkikh <Igor.Russkikh@...antia.com>
Date: Wed, 21 Nov 2018 10:13:48 +0000

> @@ -832,6 +832,10 @@ static struct sk_buff *aqc111_tx_fixup(struct usbnet *dev, struct sk_buff *skb,
>  	/*Length of actual data*/
>  	tx_desc |= skb->len & AQ_TX_DESC_LEN_MASK;
>  
> +	/* TSO MSS */
> +	tx_desc |= ((u64)(skb_shinfo(skb)->gso_size & AQ_TX_DESC_MSS_MASK)) <<
> +		   AQ_TX_DESC_MSS_SHIFT;
 ...
> +#define AQ_TX_DESC_MSS_MASK	0x7FFF

This implies a GSO size limit, which you need to advertise properly in
netdevice->gso_max_size.

Also, where is the TSO feature flag being set to actually enable the
stack sending your GSO frames?