netdev - Re: [PATCH v3 net-next 13/21] net: usb: aqc111: Add support for TSO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bc7ced62-a9f9-4297-fdca-ee4f0bba0dfe@aquantia.com>
Date:   Fri, 23 Nov 2018 08:58:32 +0000
From:   Igor Russkikh <Igor.Russkikh@...antia.com>
To:     David Miller <davem@...emloft.net>
CC:     "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "andrew@...n.ch" <andrew@...n.ch>,
        Dmitry Bezrukov <Dmitry.Bezrukov@...antia.com>
Subject: Re: [PATCH v3 net-next 13/21] net: usb: aqc111: Add support for TSO

Hi David,

On 22.11.2018 22:17, David Miller wrote:
> From: Igor Russkikh <Igor.Russkikh@...antia.com>
> Date: Wed, 21 Nov 2018 10:13:48 +0000
> 
>> @@ -832,6 +832,10 @@ static struct sk_buff *aqc111_tx_fixup(struct usbnet *dev, struct sk_buff *skb,
>>  	/*Length of actual data*/
>>  	tx_desc |= skb->len & AQ_TX_DESC_LEN_MASK;
>>  
>> +	/* TSO MSS */
>> +	tx_desc |= ((u64)(skb_shinfo(skb)->gso_size & AQ_TX_DESC_MSS_MASK)) <<
>> +		   AQ_TX_DESC_MSS_SHIFT;
>  ...
>> +#define AQ_TX_DESC_MSS_MASK	0x7FFF
> 
> This implies a GSO size limit, which you need to advertise properly in
> netdevice->gso_max_size.

Right, will do this.
Thanks for your other comments as well, will fix in v4.

> Also, where is the TSO feature flag being set to actually enable the
> stack sending your GSO frames?

Thats the same patch:

 /* Feature. ********************************************/
 #define AQ_SUPPORT_FEATURE	(NETIF_F_SG | NETIF_F_IP_CSUM |\
-				 NETIF_F_IPV6_CSUM | NETIF_F_RXCSUM)
+				 NETIF_F_IPV6_CSUM | NETIF_F_RXCSUM |\
+				 NETIF_F_TSO)
 
 #define AQ_SUPPORT_HW_FEATURE	(NETIF_F_SG | NETIF_F_IP_CSUM |\
-				 NETIF_F_IPV6_CSUM | NETIF_F_RXCSUM)
+				 NETIF_F_IPV6_CSUM | NETIF_F_RXCSUM |\
+				 NETIF_F_TSO)


Regards,
  Igor