netdev - Re: [PATCH v2 net-next] ptp: Fix pass zero to ERR_PTR() in ptp_clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181123.180421.2263933715335445413.davem@davemloft.net>
Date:   Fri, 23 Nov 2018 18:04:21 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     yuehaibing@...wei.com
Cc:     richardcochran@...il.com, dmitry.torokhov@...il.com,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next] ptp: Fix pass zero to ERR_PTR() in
 ptp_clock_register

From: YueHaibing <yuehaibing@...wei.com>
Date: Fri, 23 Nov 2018 09:54:55 +0800

> Fix smatch warning:
> 
> drivers/ptp/ptp_clock.c:298 ptp_clock_register() warn:
>  passing zero to 'ERR_PTR'
> 
> 'err' should be set while device_create_with_groups and
> pps_register_source fails
> 
> Fixes: 85a66e550195 ("ptp: create "pins" together with the rest of attributes")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Applied.