netdev - Re: [PATCH net-next 2/4] qede: Simplify the usage of qede-flags.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181123.180728.2152571006391766319.davem@davemloft.net>
Date:   Fri, 23 Nov 2018 18:07:28 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     sudarsana.kalluru@...ium.com
Cc:     netdev@...r.kernel.org, Ariel.Elior@...ium.com,
        Michal.Kalderon@...ium.com
Subject: Re: [PATCH net-next 2/4] qede: Simplify the usage of qede-flags.

From: Sudarsana Reddy Kalluru <sudarsana.kalluru@...ium.com>
Date: Thu, 22 Nov 2018 22:44:49 -0800

> -		edev->flags |= QEDE_FLAG_IS_VF;
> +		set_bit(QEDE_FLAGS_IS_VF, &edev->flags);
...
> -		edev->flags |= QEDE_TX_TIMESTAMPING_EN;
> +		set_bit(QEDE_FLAGS_TX_TIMESTAMPING_EN, &edev->flags);
 ...
> -		edev->flags &= ~QEDE_TX_TIMESTAMPING_EN;
> +		clear_bit(QEDE_FLAGS_TX_TIMESTAMPING_EN, &edev->flags);

Unless these operations need to be atomic, use __set_bit and __clear_bit.