netdev - Re: [PATCH v2 net] phy: Micrel KSZ8061: link failure after cable connect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181123.222351.996887956213237908.davem@davemloft.net>
Date:   Fri, 23 Nov 2018 22:23:51 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     Alexander.Onnasch@...disgyr.com
Cc:     andrew@...n.ch, f.fainelli@...il.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 net] phy: Micrel KSZ8061: link failure after cable
 connect

From: "Onnasch, Alexander (EXT)" <Alexander.Onnasch@...disgyr.com>
Date: Fri, 23 Nov 2018 09:36:11 +0000

> With Micrel KSZ8061 PHY, the link may occasionally not come up after
> Ethernet cable connect. The vendor's (Microchip, former Micrel) errata
> sheet 80000688A.pdf describes the problem and possible workarounds in
> detail, see below.
> The patch implements workaround 1, which permanently fixes the issue.
 ...
> Signed-off-by: Alexander Onnasch <alexander.onnasch@...disgyr.com>
> Reviewed-by: Andrew Lunn <andrew@...n.ch>

Something is off with your character encodings or something like that.

When I download your patch from patchwork, I see every line end with
a ^M control character.  See for yourself:

	https://patchwork.ozlabs.org/patch/1002221/mbox/

You'll need to fix this before I can apply your patch.