netdev - Re: [PATCH net-next v3 1/4] enetc: Introduce basic PF and VF ENETC ethernet drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181123.222915.1197343130823511085.davem@davemloft.net>
Date:   Fri, 23 Nov 2018 22:29:15 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     claudiu.manoil@....com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        alexandru.marginean@....com, catalin.horghidan@....com
Subject: Re: [PATCH net-next v3 1/4] enetc: Introduce basic PF and VF ENETC
 ethernet drivers

From: Claudiu Manoil <claudiu.manoil@....com>
Date: Fri, 23 Nov 2018 12:46:00 +0200

> +static int enetc_poll(struct napi_struct *napi, int budget)
> +{
> +	struct enetc_int_vector
> +		*v = container_of(napi, struct enetc_int_vector, napi);
> +	bool complete = true;
> +	int work_done;
> +	int i;
> +
> +	for (i = 0; i < v->count_tx_rings; i++) {
> +		work_done = enetc_clean_tx_ring(&v->tx_ring[i], budget);
> +		if (work_done == budget)
> +			complete = false;
> +	}

You should not count TX completion processing as NAPI poll "work".
It is relatively "free" compared to RX packet processing.