netdev - Re: [PATCH net] net: thunderx: set tso_hdrs pointer to NULL in nicvf_free_snd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181123.223334.1969691917725314747.davem@davemloft.net>
Date:   Fri, 23 Nov 2018 22:33:34 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     lorenzo.bianconi@...hat.com
Cc:     netdev@...r.kernel.org, Sunil.Goutham@...ium.com
Subject: Re: [PATCH net] net: thunderx: set tso_hdrs pointer to NULL in
 nicvf_free_snd_queue

From: Lorenzo Bianconi <lorenzo.bianconi@...hat.com>
Date: Fri, 23 Nov 2018 18:28:01 +0100

> Reset snd_queue tso_hdrs pointer to NULL in nicvf_free_snd_queue routine
> since it is used to check if tso dma descriptor queue has been previously
> allocated. The issue can be triggered with the following reproducer:
> 
> $ip link set dev enP2p1s0v0 xdpdrv obj xdp_dummy.o
> $ip link set dev enP2p1s0v0 xdpdrv off
 ...
> where xdp_dummy.c is a simple bpf program that forwards the incoming
> frames to the network stack (available here:
> https://github.com/altoor/xdp_walkthrough_examples/blob/master/sample_1/xdp_dummy.c)
> 
> Fixes: 05c773f52b96 ("net: thunderx: Add basic XDP support")
> Fixes: 4863dea3fab0 ("net: Adding support for Cavium ThunderX network
> controller")
> 
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@...hat.com>

Applied and queued up for -stable, but please in the future:

1) Do not break up long "Fixes: " tag lines, it must be keep as a single
   uninterrupted line for grep'ability etc.

2) Do not put an empty line between "Fixes: " and other tags.  All tags
   are equal, and appear in a straight uninterrupted sequence of lines.

Thank you.