netdev - RE: [PATCH net-next v2 0/4] qed* enhancements series

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <MW2PR07MB41393B94ED341E4DAF8CB9AD8AD60@MW2PR07MB4139.namprd07.prod.outlook.com>
Date:   Sun, 25 Nov 2018 04:43:35 +0000
From:   "Kalluru, Sudarsana" <Sudarsana.Kalluru@...ium.com>
To:     David Miller <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Elior, Ariel" <Ariel.Elior@...ium.com>,
        "Kalderon, Michal" <Michal.Kalderon@...ium.com>
Subject: RE: [PATCH net-next v2 0/4] qed* enhancements series


-----Original Message-----
From: David Miller [mailto:davem@...emloft.net] 
Sent: 25 November 2018 07:02
To: Kalluru, Sudarsana <Sudarsana.Kalluru@...ium.com>
Cc: netdev@...r.kernel.org; Elior, Ariel <Ariel.Elior@...ium.com>; Kalderon, Michal <Michal.Kalderon@...ium.com>
Subject: Re: [PATCH net-next v2 0/4] qed* enhancements series

External Email

From: Sudarsana Reddy Kalluru <sudarsana.kalluru@...ium.com>
Date: Fri, 23 Nov 2018 23:42:29 -0800

> v2: Use __set_bit()/__clear_bit() where data access doesn't need to be
>     atomic.

Wait.

How does this interact with the clear_bit_unlock() used by the qede PTP code?
You can't really mix atomic and non-atomic accesses to edev->flags .

Hi Dave,
    I missed this point, thanks a lot for your help/info. Will revert it to use set/clear_bit() respectively and, send the V3 version of the series.

Thanks,
Sudarsana