netdev - Re: [PATCH net-next v2 0/4] qed* enhancements series

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 24 Nov 2018 17:32:24 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     sudarsana.kalluru@...ium.com
Cc:     netdev@...r.kernel.org, Ariel.Elior@...ium.com,
        Michal.Kalderon@...ium.com
Subject: Re: [PATCH net-next v2 0/4] qed* enhancements series

From: Sudarsana Reddy Kalluru <sudarsana.kalluru@...ium.com>
Date: Fri, 23 Nov 2018 23:42:29 -0800

> v2: Use __set_bit()/__clear_bit() where data access doesn't need to be
>     atomic.

Wait.

How does this interact with the clear_bit_unlock() used by the qede PTP code?
You can't really mix atomic and non-atomic accesses to edev->flags
.