netdev - Re: [PATCH] net: qualcomm: rmnet: move null check on dev before dereferecing it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181124.174053.2148461318593755323.davem@davemloft.net>
Date:   Sat, 24 Nov 2018 17:40:53 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     colin.king@...onical.com
Cc:     subashab@...eaurora.org, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: qualcomm: rmnet: move null check on dev before
 dereferecing it

From: Colin King <colin.king@...onical.com>
Date: Sat, 24 Nov 2018 15:03:02 +0000

> From: Colin Ian King <colin.king@...onical.com>
> 
> Currently dev is dereferenced by the call dev_net(dev) before dev is null
> checked.  Fix this by null checking dev before the potential null
> pointer dereference.
> 
> Detected by CoverityScan, CID#1462955 ("Dereference before null check")
> 
> Fixes: 23790ef12082 ("net: qualcomm: rmnet: Allow to configure flags for existing devices")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied to net-next.