netdev - Re: [PATCH net] tcp: address problems caused by EDT misshaps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181124.174220.103125011987920229.davem@davemloft.net>
Date:   Sat, 24 Nov 2018 17:42:20 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, ncardwell@...gle.com, ycheng@...gle.com,
        eric.dumazet@...il.com
Subject: Re: [PATCH net] tcp: address problems caused by EDT misshaps

From: Eric Dumazet <edumazet@...gle.com>
Date: Sat, 24 Nov 2018 09:12:24 -0800

> When a qdisc setup including pacing FQ is dismantled and recreated,
> some TCP packets are sent earlier than instructed by TCP stack.
> 
> TCP can be fooled when ACK comes back, because the following
> operation can return a negative value.
> 
>     tcp_time_stamp(tp) - tp->rx_opt.rcv_tsecr;
> 
> Some paths in TCP stack were not dealing properly with this,
> this patch addresses four of them.
> 
> Fixes: ab408b6dc744 ("tcp: switch tcp and sch_fq to new earliest departure time model")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied, thanks Eric.