netdev - Re: [PATCH] net: tcp: add correct check for tcp_retransmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181126101630.rcl2futyxqg7ejpj@gmail.com>
Date:   Mon, 26 Nov 2018 00:16:30 -1000
From:   Joey Pabalinas <joeypabalinas@...il.com>
To:     Sharath Chandra Vurukala <sharathv@...eaurora.org>
Cc:     netdev@...r.kernel.org, kapandey@...eaurora.org,
        chinagar@...eaurora.org, Joey Pabalinas <joeypabalinas@...il.com>
Subject: Re: [PATCH] net: tcp: add correct check for tcp_retransmit_skb()

On Mon, Nov 26, 2018 at 03:05:50PM +0530, Sharath Chandra Vurukala wrote:
> when the tcp_retranmission_timer expires and tcp_retranmsit_skb is
> called if the retranmsission fails due to local congestion,
> backoff should not incremented.
> 
> tcp_retransmit_skb() returns non-zero negative value in some cases of
> failure but the caller tcp_retransmission_timer() has a check for
> failure which checks if the return value is greater than zero.
> The check is corrected to check for non-zero value.
> 
> Change-Id: I494fed73b2e385216402c91e9558d5c2884add5b
> Signed-off-by: Sharath Chandra Vurukala <sharathv@...eaurora.org>

You are right, tcp_retransmit_skb() calls `int err = __tcp_retransmit_skb()`
which returns non-zero on error.

Reviewed-by: Joey Pabalinas <joeypabalinas@...il.com>

-- 
Cheers,
Joey Pabalinas

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)