netdev - Re: [PATCH] net: tcp: add correct check for tcp_retransmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 27 Nov 2018 16:15:42 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     sharathv@...eaurora.org
Cc:     netdev@...r.kernel.org, kapandey@...eaurora.org,
        chinagar@...eaurora.org
Subject: Re: [PATCH] net: tcp: add correct check for tcp_retransmit_skb()

From: Sharath Chandra Vurukala <sharathv@...eaurora.org>
Date: Mon, 26 Nov 2018 15:05:50 +0530

> when the tcp_retranmission_timer expires and tcp_retranmsit_skb is
> called if the retranmsission fails due to local congestion,
> backoff should not incremented.
> 
> tcp_retransmit_skb() returns non-zero negative value in some cases of
> failure but the caller tcp_retransmission_timer() has a check for
> failure which checks if the return value is greater than zero.
> The check is corrected to check for non-zero value.
> 
> Change-Id: I494fed73b2e385216402c91e9558d5c2884add5b

No changeids please.

> Signed-off-by: Sharath Chandra Vurukala <sharathv@...eaurora.org>

This patch doesn't apply cleanly to my net tree.