netdev - Re: [PATCH] mv88e6060 station roaming

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20181127044143.GB3181@lunn.ch>
Date:   Tue, 27 Nov 2018 05:41:43 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Alacn <alacn1@...il.com>
Cc:     Vivien Didelot <vivien.didelot@...oirfairelinux.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mv88e6060 station roaming

On Mon, Nov 26, 2018 at 09:31:02PM -0200, Alacn wrote:
> hello,
> 
> I'm sending a patch for Marvell 88e6060 driver.
> 
> Problem description:
> Multiple APs with inter-AP roaming connected to different ports,
> when station moves from one AP on one port to another AP on another port,
> traffic flow breaks down because the learning table is not updated.
> 
> 
> When Marvell's mac learning is enabled it drops all frames that
> arrive from a MAC address that is on a different port at learning table.
> It doesn't update learning table and breaks station roaming.
> 
> 
> This patch disable Marvell 88E6060 hardware level mac learning and let it
> be handled by the kernel.

Hi Anderson.

> @@ -145,8 +144,7 @@

        /* Enable automatic address learning, set the address
         * database size to 1024 entries, and set the default aging
         * time to 5 minutes.
         */


>   * time to 5 minutes.
>   */
>   REG_WRITE(REG_GLOBAL, GLOBAL_ATU_CONTROL,
> -   GLOBAL_ATU_CONTROL_ATUSIZE_1024 |
> -   GLOBAL_ATU_CONTROL_ATE_AGE_5MIN);
> +   GLOBAL_ATU_CONTROL_LEARNDIS);

Please update the comment as well.

       Thanks
	Andrew