netdev - Re: [PATCH v3 13/13] nvme-tcp: add NVMe over TCP host driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <43ad34a0-799d-5f78-a07f-e2c51f64a854@grimberg.me>
Date:   Mon, 26 Nov 2018 23:48:01 -0800
From:   Sagi Grimberg <sagi@...mberg.me>
To:     Max Gurtovoy <maxg@...lanox.com>, Christoph Hellwig <hch@....de>
Cc:     linux-nvme@...ts.infradead.org, linux-block@...r.kernel.org,
        netdev@...r.kernel.org, Keith Busch <keith.busch@...el.com>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH v3 13/13] nvme-tcp: add NVMe over TCP host driver


>>> This looks odd.  It's not really the timeout handlers job to
>>> call nvme_end_request here.
>>
>> Well.. if we are not yet LIVE, we will not trigger error
>> recovery, which means nothing will complete this command so
>> something needs to do it...
>>
>> I think that we need it for rdma too..
> 
> 
> yes we do. and we've patches in our pipe.
> 
> I'm thinking on a wider change in the error/recovery flows but might 
> send it "as is" meanwhile.

I have it too in the pipe. Do you want to send it out or should I?