netdev - Re: [PATCH v3 13/13] nvme-tcp: add NVMe over TCP host driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6431353b-cacc-55a4-f8f8-696e4bb26bf8@mellanox.com>
Date:   Tue, 27 Nov 2018 12:20:48 +0200
From:   Max Gurtovoy <maxg@...lanox.com>
To:     Sagi Grimberg <sagi@...mberg.me>, Christoph Hellwig <hch@....de>
CC:     <linux-nvme@...ts.infradead.org>, <linux-block@...r.kernel.org>,
        <netdev@...r.kernel.org>, Keith Busch <keith.busch@...el.com>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH v3 13/13] nvme-tcp: add NVMe over TCP host driver


On 11/27/2018 9:48 AM, Sagi Grimberg wrote:
>
>>>> This looks odd.  It's not really the timeout handlers job to
>>>> call nvme_end_request here.
>>>
>>> Well.. if we are not yet LIVE, we will not trigger error
>>> recovery, which means nothing will complete this command so
>>> something needs to do it...
>>>
>>> I think that we need it for rdma too..
>>
>>
>> yes we do. and we've patches in our pipe.
>>
>> I'm thinking on a wider change in the error/recovery flows but might 
>> send it "as is" meanwhile.
>
> I have it too in the pipe. Do you want to send it out or should I?


go for it. We've several patches that are under testing and review 
currently.