netdev - Re: [PATCH net-next 1/2] rtnetlink: remove a level of indentation in rtnl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b09d3fe1-c372-f8e2-2dc8-3504cb811b5d@gmail.com>
Date:   Wed, 28 Nov 2018 10:53:09 -0700
From:   David Ahern <dsahern@...il.com>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>, davem@...emloft.net
Cc:     jiri@...nulli.us, roopa@...ulusnetworks.com,
        christian.brauner@...ntu.com, netdev@...r.kernel.org,
        oss-drivers@...ronome.com
Subject: Re: [PATCH net-next 1/2] rtnetlink: remove a level of indentation in
 rtnl_newlink()

On 11/27/18 11:32 PM, Jakub Kicinski wrote:
> rtnl_newlink() used to create VLAs based on link kind.  Since
> commit ccf8dbcd062a ("rtnetlink: Remove VLA usage") statically
> sized array is created on the stack, so there is no more use
> for a separate code block that used to be the VLA's live range.
> 
> While at it christmas tree the variables.  Note that there is
> a goto-based retry so to be on the safe side the variables can
> no longer be initialized in place.  It doesn't seem to matter,
> logically, but why make the code harder to read..
> 
> Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
> ---
>  net/core/rtnetlink.c | 313 +++++++++++++++++++++----------------------
>  1 file changed, 154 insertions(+), 159 deletions(-)

Reviewed-by: David Ahern <dsahern@...il.com>