netdev - Re: [PATCH net-next 2/2] rtnetlink: avoid frame size warning in rtnl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3c9b50e3-a233-9120-16eb-20fa1a264751@gmail.com>
Date:   Wed, 28 Nov 2018 10:53:47 -0700
From:   David Ahern <dsahern@...il.com>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>, davem@...emloft.net
Cc:     jiri@...nulli.us, roopa@...ulusnetworks.com,
        christian.brauner@...ntu.com, netdev@...r.kernel.org,
        oss-drivers@...ronome.com
Subject: Re: [PATCH net-next 2/2] rtnetlink: avoid frame size warning in
 rtnl_newlink()

On 11/27/18 11:32 PM, Jakub Kicinski wrote:
> Standard kernel compilation produces the following warning:
> 
> net/core/rtnetlink.c: In function ‘rtnl_newlink’:
> net/core/rtnetlink.c:3232:1: warning: the frame size of 1288 bytes is larger than 1024 bytes [-Wframe-larger-than=]
>  }
>   ^
> 
> This should not really be an issue, as rtnl_newlink() stack is
> generally quite shallow.
> 
> Fix the warning by allocating attributes with kmalloc() in a wrapper
> and passing it down to rtnl_newlink(), avoiding complexities on error
> paths.
> 
> Alternatively we could kmalloc() some structure within rtnl_newlink(),
> slave attributes look like a good candidate.  In practice it adds to
> already rather high complexity and length of the function.
> 
> Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
> ---
>  net/core/rtnetlink.c | 20 +++++++++++++++++---
>  1 file changed, 17 insertions(+), 3 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...il.com>