netdev - Re: [PATCH 0/3]: net: dsa: mt7530: support MT7530 in the MT7621 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181130134240.GD11747@lunn.ch>
Date:   Fri, 30 Nov 2018 14:42:40 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Bjørn Mork <bjorn@...k.no>
Cc:     gerg@...nel.org, sean.wang@...iatek.com,
        vivien.didelot@...oirfairelinux.com, f.fainelli@...il.com,
        netdev@...r.kernel.org, blogic@...nwrt.org, neil@...wn.name,
        René van Dorst <opensource@...rst.com>
Subject: Re: [PATCH 0/3]: net: dsa: mt7530: support MT7530 in the MT7621 SoC

> > 1. TX packets are not getting an IP header checksum via the normal
> >    off-loaded checksumming when in DSA mode. I have to switch off
> >    NETIF_F_IP_CSUM, so the software stack generates the checksum.
> >    That checksum offloading works ok when not using the 7530 DSA driver.
> 
> Hmm.  How do I test this?

If there are no IP checksums in the frame, the receiver will generally
drop the packet.

ethtool -k will show you what features the MAC has in terms of
offloading. So if you see NETIF_F_IP_CSUM, you know the MAC should be
doing it in hardware.

      Andrew