netdev - Re: [PATCH net] rtnetlink: Refine sanity checks in rtnl_fdb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACT4Y+aGZy6vw2ysNwTuBOOTyagRDz-MuYrz2DVkjzs7DuQGCA@mail.gmail.com>
Date:   Fri, 30 Nov 2018 16:10:29 +0000
From:   Dmitry Vyukov <dvyukov@...gle.com>
To:     Ido Schimmel <idosch@...sch.org>
Cc:     David Ahern <dsahern@...il.com>,
        Eric Dumazet <edumazet@...gle.com>,
        David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Eric Dumazet <eric.dumazet@...il.com>,
        syzkaller <syzkaller@...glegroups.com>, idosch@...lanox.com
Subject: Re: [PATCH net] rtnetlink: Refine sanity checks in rtnl_fdb_{add|del}

On Fri, Nov 30, 2018 at 4:02 PM, Ido Schimmel <idosch@...sch.org> wrote:
> On Fri, Nov 30, 2018 at 08:59:09AM -0700, David Ahern wrote:
>> This does not repro for me:
>> # ./a.out
>> Invalid address length 6 - must be 4 bytes
>> RTNETLINK answers: No buffer space available
>> RTNETLINK answers: Operation not supported
>> Invalid address length 6 - must be 4 bytes
>> Invalid address length 6 - must be 4 bytes
>> Invalid address length 6 - must be 4 bytes
>> Invalid address length 6 - must be 16 bytes
>> Invalid address length 6 - must be 16 bytes
>> Invalid address length 6 - must be 16 bytes
>>
>> config available>?
>
> You need a kernel with kmsan. See:
> https://github.com/google/kmsan


Another option may be to spray memory at the allocation stack with
some distinctive byte pattern and then check this pattern at the use
stack. Not 100% sounds, but should be enough for testing.