netdev - Re: [PATCH net 2/2] nfp: flower: prevent offload if rhashtable insert fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181130.132525.2032550660695967474.davem@davemloft.net>
Date:   Fri, 30 Nov 2018 13:25:25 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     jakub.kicinski@...ronome.com
Cc:     oss-drivers@...ronome.com, netdev@...r.kernel.org,
        john.hurley@...ronome.com, sfr@...b.auug.org.au
Subject: Re: [PATCH net 2/2] nfp: flower: prevent offload if rhashtable
 insert fails

From: Jakub Kicinski <jakub.kicinski@...ronome.com>
Date: Tue, 27 Nov 2018 14:04:12 -0800

> From: John Hurley <john.hurley@...ronome.com>
> 
> For flow offload adds, if the rhash insert code fails, the flow will still
> have been offloaded but the reference to it in the driver freed.
> 
> Re-order the offload setup calls to ensure that a flow will only be written
> to FW if a kernel reference is held and stored in the rhashtable. Remove
> this hashtable entry if the offload fails.
> 
> Fixes: c01d0efa5136 ("nfp: flower: use rhashtable for flow caching")
> Signed-off-by: John Hurley <john.hurley@...ronome.com>
> Reviewed-by: Pieter Jansen van Vuuren <pieter.jansenvanvuuren@...ronome.com>
> Reviewed-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
> ---
> Merge note: there will be a slight merge conflict with net-next
> here:
>  - the first argument of nfp_flower_xmit_flow() changed from 'netdev'
>    to 'app';
>  - we only bump the port offload cnt if (port).
> 
> FWIW the net-next version of the patch can be found at:
> 
>      git://git.kernel.org/pub/scm/linux/kernel/git/kuba/linux.git
> 
>      17ed95873d51 nfp: flower: prevent offload if rhashtable insert fails
>      d857fc8f472b nfp: flower: release metadata on offload failure
> 
> CC: Stephen Rothwell <sfr@...b.auug.org.au> # for linux-next

Applied.