netdev - Re: [PATCH v3 net-next 0/4] tcp: take a bit more care of backlog stress

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181130.132747.799494882078145665.davem@davemloft.net>
Date:   Fri, 30 Nov 2018 13:27:47 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, jean-louis@...ond.be, ncardwell@...gle.com,
        ycheng@...gle.com, eric.dumazet@...il.com
Subject: Re: [PATCH v3 net-next 0/4] tcp: take a bit more care of backlog
 stress

From: Eric Dumazet <edumazet@...gle.com>
Date: Tue, 27 Nov 2018 14:41:59 -0800

> While working on the SACK compression issue Jean-Louis Dupond
> reported, we found that his linux box was suffering very hard
> from tail drops on the socket backlog queue.
> 
> First patch hints the compiler about sack flows being the norm.
> 
> Second patch changes non-sack code in preparation of the ack
> compression.
> 
> Third patch fixes tcp_space() to take backlog into account.
> 
> Fourth patch is attempting coalescing when a new packet must
> be added to the backlog queue. Cooking bigger skbs helps
> to keep backlog list smaller and speeds its handling when
> user thread finally releases the socket lock.
> 
> v3: Neal/Yuchung feedback addressed :
>      Do not aggregate if any skb has URG bit set.
>      Do not aggregate if the skbs have different ECE/CWR bits
> 
> v2: added feedback from Neal : tcp: take care of compressed acks in tcp_add_reno_sack() 
>     added : tcp: hint compiler about sack flows
> 	added : tcp: make tcp_space() aware of socket backlog

Series applied, thanks Eric.

I'll push this out after the build check finishes.