netdev - Re: [PATCH] dma-debug: hns_enet_drv could use more DMA entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181130084203.GA19812@lst.de>
Date:   Fri, 30 Nov 2018 09:42:03 +0100
From:   Christoph Hellwig <hch@....de>
To:     Qian Cai <cai@....us>
Cc:     hch@....de, m.szyprowski@...sung.com, robin.murphy@....com,
        yisen.zhuang@...wei.com, salil.mehta@...wei.com,
        iommu@...ts.linux-foundation.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dma-debug: hns_enet_drv could use more DMA entries

On Thu, Nov 29, 2018 at 10:54:56PM -0500, Qian Cai wrote:
>  /* allow architectures to override this if absolutely required */
>  #ifndef PREALLOC_DMA_DEBUG_ENTRIES
> +/* amount of DMA mappings on this driver is huge. */
> +#ifdef	HNS_ENET
> +#define PREALLOC_DMA_DEBUG_ENTRIES (1 << 17)
> +#else
>  #define PREALLOC_DMA_DEBUG_ENTRIES (1 << 16)
>  #endif
> +#endif

How would this be defined in a header that leaks into this file?

I think we need to turn PREALLOC_DMA_DEBUG_ENTRIES into a user
selectable config options, as I really don't want to collect hacks like
this.