netdev - Re: [PATCH] dma-debug: hns_enet_drv could use more DMA entries

Open Source and information security mailing list archives

Message-ID: <23da2426-a397-a33c-cfd8-dba7b3c1aaee@huawei.com>
Date:   Fri, 30 Nov 2018 09:16:12 +0000
From:   John Garry <john.garry@...wei.com>
To:     Christoph Hellwig <hch@....de>, Qian Cai <cai@....us>
CC:     <robin.murphy@....com>, <linux-kernel@...r.kernel.org>,
        <iommu@...ts.linux-foundation.org>, <netdev@...r.kernel.org>,
        <yisen.zhuang@...wei.com>, Linuxarm <linuxarm@...wei.com>
Subject: Re: [PATCH] dma-debug: hns_enet_drv could use more DMA entries

+

Pasting original message at bottom.


On 30/11/2018 08:42, Christoph Hellwig wrote:
> On Thu, Nov 29, 2018 at 10:54:56PM -0500, Qian Cai wrote:
>>  /* allow architectures to override this if absolutely required */
>>  #ifndef PREALLOC_DMA_DEBUG_ENTRIES
>> +/* amount of DMA mappings on this driver is huge. */
>> +#ifdef	HNS_ENET
>> +#define PREALLOC_DMA_DEBUG_ENTRIES (1 << 17)
>> +#else
>>  #define PREALLOC_DMA_DEBUG_ENTRIES (1 << 16)
>>  #endif
>> +#endif
>
> How would this be defined in a header that leaks into this file?
>
> I think we need to turn PREALLOC_DMA_DEBUG_ENTRIES into a user
> selectable config options, as I really don't want to collect hacks like
> this.
> _______________________________________________
> iommu mailing list
> iommu@...ts.linux-foundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/iommu
>
>







The amount of DMA mappings from Hisilicon HNS ethernet devices is huge,
so it could trigger "DMA-API: debugging out of memory - disabling".

hnae_get_handle [1]
   hnae_init_queue
     hnae_init_ring
       hnae_alloc_buffers [2]
         debug_dma_map_page
           dma_entry_alloc

[1] for (i = 0; i < handle->q_num; i++)
[2] for (i = 0; i < ring->desc_num; i++)

On this Huawei TaiShan 2280 aarch64 server, it has reached the limit
already,

4 (ports) x 16 (handles) x 1024 (rings) = 65536

Signed-off-by: Qian Cai <cai@....us>
---
  kernel/dma/debug.c | 5 +++++
  1 file changed, 5 insertions(+)

diff --git a/kernel/dma/debug.c b/kernel/dma/debug.c
index 231ca4628062..ae91689cc9ad 100644
--- a/kernel/dma/debug.c
+++ b/kernel/dma/debug.c
@@ -43,8 +43,13 @@

  /* allow architectures to override this if absolutely required */
  #ifndef PREALLOC_DMA_DEBUG_ENTRIES
+/* amount of DMA mappings on this driver is huge. */
+#ifdef	HNS_ENET
+#define PREALLOC_DMA_DEBUG_ENTRIES (1 << 17)
+#else
  #define PREALLOC_DMA_DEBUG_ENTRIES (1 << 16)
  #endif
+#endif

  enum {
  	dma_debug_single,




lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives