netdev - Re: [PATCH bpf-next v2] bpf: allow BPF read access to qdisc pkt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <efdb9f0b-e9c6-8273-ebcf-34dba40d03c7@iogearbox.net>
Date:   Mon, 3 Dec 2018 21:44:16 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Willem de Bruijn <willemdebruijn.kernel@...il.com>,
        netdev@...r.kernel.org
Cc:     ast@...nel.org, peterpenkov96@...il.com, vladum@...gle.com,
        liu.song.a23@...il.com, Petar Penkov <ppenkov@...gle.com>,
        Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH bpf-next v2] bpf: allow BPF read access to qdisc pkt_len

On 12/03/2018 02:18 AM, Willem de Bruijn wrote:
> From: Petar Penkov <ppenkov@...gle.com>
> 
> The pkt_len field in qdisc_skb_cb stores the skb length as it will
> appear on the wire after segmentation. For byte accounting, this value
> is more accurate than skb->len. It is computed on entry to the TC
> layer, so only valid there.
> 
> Allow read access to this field from BPF tc classifier and action
> programs. The implementation is analogous to tc_classid, aside from
> restricting to read access.
> 
> To distinguish it from skb->len and self-describe export as wire_len.
> 
> Changes v1->v2
>   - Rename pkt_len to wire_len
> 
> Signed-off-by: Petar Penkov <ppenkov@...gle.com>
> Signed-off-by: Vlad Dumitrescu <vladum@...gle.com>
> Signed-off-by: Willem de Bruijn <willemb@...gle.com>

Applied to bpf-next, thanks!